Dmp 4065 unstructured to arm data store stuck in arm ingestion #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
ciaranca,
DanielKChristou and
JoshuaGlassKainos
and removed request for
a team
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
74467b6 to
48138fe
Compare
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2319
labels
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
48138fe to
984f208
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
984f208 to
34a8dd3
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
28375cb to
6abe4e0
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
2 times, most recently
from
10b8ed0 to
556fb58
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
556fb58 to
cf17a5a
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
2 times, most recently
from
3b11d2d to
d61f4ea
Compare
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
d61f4ea to
194f1d4
Compare
jackmaloney
reviewed
Dec 5, 2024
...ionTest/java/uk/gov/hmcts/darts/common/repository/ExternalObjectDirectoryRepositoryTest.java
Outdated
Show resolved
Hide resolved
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
194f1d4 to
4f0d8f5
Compare
src/main/java/uk/gov/hmcts/darts/arm/exception/UnableToReadArmFileException.java
Show resolved
Hide resolved
| @@ -44,21 +44,19 @@ void testGetDirectoryIfMediaDate24Hours() throws Exception { | |||
|
|
|||
| int setupHoursBeforeCurrentTime = 24; | |||
|
|
|||
| // setup the test data | |||
| // given | |||
There was a problem hiding this comment.
Since we're touching/improving the tests, consider updating the test names to align with the new standard.
|
|
||
|
|
||
| @Test | ||
| void updateEodByIdAndStatusForArmPush() throws InvocationTargetException, NoSuchMethodException, IllegalAccessException { |
There was a problem hiding this comment.
Align with new naming standard.
| @@ -465,4 +457,27 @@ void findAllByStatusAndDataIngestionTsBetweenAndLimit() throws InvocationTargetE | |||
| }); | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| void updateEodByIdAndStatus() throws InvocationTargetException, NoSuchMethodException, IllegalAccessException { | |||
There was a problem hiding this comment.
Align with new naming standard.
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
60f62df to
4a0d695
Compare
…tion' Merged in master
…tion' Added a shutdown hook to reset states before closing down
…tion' Merged in master
…tion' Added a shutdown hook to reset states before closing down
…tion' Added a shutdown hook to reset states before closing down
…tion' Test tidy up
…tion' Merged in master
…tion' Merged in master
…tion' Fixed issue with mis merge
…tion' Fixed issue with mis merge
…tion' Fixed issue with mis merge
karen-hedges
force-pushed
the
DMP-4065-UnstructuredToArmDataStoreStuckInArmIngestion
branch
from
8633727 to
8ccba0e
Compare
…tion' Merged in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4065
Change description
Added a shutdown hook to change any In progress ARM Push EOD's to raw data failed. Includes some fixes to PMD complaints.
Does this PR introduce a breaking change? (check one with "x")