DMP 4161 Darts API should only accept uppercase courthouse and courtroom from Portal #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomReed
requested review from
davet1985,
jackmaloney,
cakeben,
danielwilsonkainos,
SalimKainos and
ieuanb74
and removed request for
a team
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2351
labels
|
@TomReed think this needs to include the POST /admin/courthouses and PATCH /admin/courthouses endpoints? |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Checks on: |
jackmaloney
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
DMP-4161
Change description
I used the AC from the related Portal UI item DMP-4160 and applied to checks to corresponding endpoints in the api.
Endpoints with uppercase checks:
AC3: searching for a courtroom display name in admin portal of DMP-4160 does not appear to have a corresponding backend endpoint and when searching in the portal there is no network activity. Assumed retrieved from Angular scope as reference data?
Additionally have added uppercase check on these endpoints not covered by 4161
Does this PR introduce a breaking change? (check one with "x")
Last two endpoints need implementing if front end