DMP-3534: Retention Confidence #2382
Conversation
chrisbellingham-hmcts
force-pushed
the
dmp-3534-retention-confidence-category-mapper
branch
from
0b674db to
a78340f
Compare
chrisbellingham-hmcts
force-pushed
the
dmp-3534-retention-confidence-category-mapper
branch
from
a78340f to
7eaab33
Compare
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2382
labels
|
|
||
| // when | ||
| closeOldCasesProcessor.closeCases(2); | ||
|
|
||
| // then | ||
| assertTrue(courtCase.getClosed()); | ||
| assertEquals(CURRENT_DATE_TIME, courtCase.getRetConfUpdatedTs()); |
There was a problem hiding this comment.
Author note: The class under test no longer has responsibility for setting this attribute, therefore the assertion is removed here. Dedicated unit tests exist in RetentionServiceImplTest to verify this attribute is set correctly.
| verify(caseRepository).save(courtCaseEntityArgumentCaptor.capture()); | ||
| CourtCaseEntity savedCourtCase = courtCaseEntityArgumentCaptor.getValue(); | ||
| assertEquals(RetentionConfidenceReasonEnum.MANUAL_OVERRIDE, savedCourtCase.getRetConfReason()); | ||
| assertEquals(RetentionConfidenceScoreEnum.CASE_PERFECTLY_CLOSED, savedCourtCase.getRetConfScore()); | ||
| assertEquals(CURRENT_DATE_TIME, savedCourtCase.getRetConfUpdatedTs()); |
There was a problem hiding this comment.
Author note: The class under test no longer has responsibility for setting these attributes, therefore the assertions are removed here. Dedicated unit tests exist in RetentionServiceImplTest to verify these attributes are set correctly.
Similar comment applies to the other tests in this test class.
src/main/java/uk/gov/hmcts/darts/retention/enums/RetentionConfidenceScoreEnum.java
Show resolved
Hide resolved
chrisbellingham-hmcts
requested review from
davet1985,
jackmaloney,
cakeben,
c4seyla,
cpareek and
mananpatel26
and removed request for
a team
src/main/java/uk/gov/hmcts/darts/common/entity/RetentionConfidenceCategoryMapperEntity.java
Show resolved
Hide resolved
…g value for confidenceReason; add associated test
|
|
||
| OffsetDateTime closeDate = OffsetDateTime.now().minusYears(7); | ||
|
|
||
| EventEntity eventEntity1 = dartsDatabase.getEventStub().createEvent(hearing, 8);//Re-examination |
There was a problem hiding this comment.
What does comment on this line mean? Is it the event name?
There was a problem hiding this comment.
I will review the comments in this test method, I have copy/pasted an existing test setup to test a slightly different scenario here.
There was a problem hiding this comment.
The existing comments were relating to the name of the event handler, but since the primary keys were hard-coded they have since went out of sync. Regardless, the choice of event handler doesn't matter, we just need some event.
I've reworked this test to remove the hard-coded primary keys and have simplified it somewhat.
src/integrationTest/java/uk/gov/hmcts/darts/cases/service/CloseOldCasesProcessorTest.java
Show resolved
Hide resolved
DMP-3534
Two fundamental changes in this PR:
src/main/java/uk/gov/hmcts/darts/retention/enums/RetentionConfidenceScoreEnum.javaretention_confidence_category_mapperto obtain these values. Seesrc/main/java/uk/gov/hmcts/darts/retention/service/impl/RetentionServiceImpl.javaSome additional work has been done to facilitate these changes:
RetentionConfidenceCategoryMapperEntityhas been updated to utilise enums rather than ints, improving code readability and aligning with the approach taken forCaseRetentionEntityandCourtCaseEntity.RetentionServiceImpl, and calling code has been adjusted to share this common code.RetentionConfidenceCategoryMapperEntityobjects for both unit and integration tests going forward.Does this PR introduce a breaking change? (check one with "x")