V72.3 #2422
Open
V72.3 #2422
+258
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates to the main schema script and retention. ERD updated also.
barry-jones50410
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
endakelly,
ozzyib and
shabmama53
and removed request for
a team
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2422
labels
Comment on lines
+192
to
+195
| --,is_standard_policy BOOLEAN | ||
| --,is_permanent_policy BOOLEAN | ||
| --,checked_ts TIMESTAMP WITH TIME ZONE | ||
| --,corrected_ts TIMESTAMP WITH TIME ZONE |
There was a problem hiding this comment.
Assuming the commented fields are not required, so can they be removed from the script to avoid any confusion?
Comment on lines
+200
to
+215
| --,case_object_name CHARACTER VARYING(255) -- to accommodate dm_sysobject_s.object_name | ||
| --,case_closed_eve_id INTEGER -- unenforced fk to event | ||
| --,tol_case_closed_ts TIMESTAMP WITH TIME ZONE | ||
| --,tol_case_closed_type CHARACTER VARYING -- enumerated type, not normalised | ||
| --,ret_retain_until_ts TIMESTAMP WITH TIME ZONE | ||
| --,aud_retain_until_ts TIMESTAMP WITH TIME ZONE | ||
| --,migration_type CHARACTER VARYING -- to indicate how we've got to this point with this record | ||
| --,migration_error_1 CHARACTER VARYING | ||
| --,migration_error_2 CHARACTER VARYING | ||
| --,migration_error_3 CHARACTER VARYING | ||
| --,migration_error_4 CHARACTER VARYING | ||
| --,ret_conf_score INTEGER | ||
| --,ret_conf_reason CHARACTER VARYING | ||
| --,ret_conf_updated_ts TIMESTAMP WITH TIME ZONE | ||
| --,tol_diff_c_close_in_days INTEGER | ||
| --,tol_diff_ret_dt_in_days INTEGER |
There was a problem hiding this comment.
Assuming the commented fields are not required, so can they be removed from the script to avoid any confusion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until tranche 2 migration comes into Modernised, scheduled for week ending 10/1/25.
updates to the main schema script and retention. ERD updated also.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")