DMP-4655 ARM RPO Amendments #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
c4seyla,
ozzyib and
manohar-hmcts
and removed request for
a team
karen-hedges
force-pushed
the
DMP-4655-ARMRPOAmendments
branch
4 times, most recently
from
3e30608 to
514898f
Compare
chrisbellingham-hmcts
approved these changes
Jan 24, 2025
1) Add UUID and _CSV to production name so that it is always unique each time its polled and pass to createExportBasedOnSearchResultsTable and getExtendedProductionsByMatter 2) Change createExportBasedOnSearchResultsTable catch feign response to handle bad request by using e.contentUTF8(), convert to BaseRpoRresponse and then pass to processCreateExportBasedOnSearchResultsTableResponse 3) Set thread sleep to 60 seconds
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
Fixed broken test
karen-hedges
force-pushed
the
DMP-4655-ARMRPOAmendments
branch
from
fd3176d to
b3042e4
Compare
Fixed broken test
Fixed broken test
hemantasharma1129
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4655
Change description
Added UUID and _CSV to production name so that it is always unique each time its polled and pass to createExportBasedOnSearchResultsTable and getExtendedProductionsByMatter
Changed createExportBasedOnSearchResultsTable catch feign response to handle bad request by using e.contentUTF8(), convert to BaseRpoRresponse and then pass to processCreateExportBasedOnSearchResultsTableResponse
Set thread sleep to 60 seconds
Added NonNull check to updateMetadata
Does this PR introduce a breaking change? (check one with "x")