Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFPL-2639: Move living situation (+ details) to the confidential tab #5796

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

DanCatchpole
Copy link
Contributor

JIRA link (if applicable)

DFPL-2639

Change description

  • If the address is marked as confidential (or via living in a refuge), move the living situation + living situation details to the confidential information tab, as may include details inadvertently on how to contact the party.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@DanCatchpole DanCatchpole changed the base branch from master to DFPL-2546 January 6, 2025 16:04
@DanCatchpole DanCatchpole merged commit 0da2a55 into DFPL-2546 Jan 6, 2025
6 of 7 checks passed
@DanCatchpole DanCatchpole deleted the DFPL-2639 branch January 6, 2025 16:04
chak-shing-lo-justice added a commit that referenced this pull request Jan 7, 2025
…#5755)

* Revert "Roll back DFPL 2546 (#5746)"

This reverts commit afee204.

* upgrade others with addressKnowV2

* Revert as master version

This reverts commit f541d55.

Reapply "Roll back DFPL 2546 (#5746)"

This reverts commit c9fc210.

* Revert "Roll back DFPL 2546 (#5746)"

This reverts commit afee204.

* Revert "addressKnowV2"

This reverts commit b6a081a.

Reapply "Roll back DFPL 2546 (#5746)"

This reverts commit eac9947.

* fix code check

* fix test

* fix test

* Update extract-confidential-data.json

* Update Other.java

* Update 2_Others.json

* Update 2_Others.json

* Update 2_Others.json

* Update 2_Others.json

* fix code check

* UpdateOthersUITest

* removeonlyTag

* update

* DFPL-2641: Move address known type to confidential tab (#5797)

* DFPL-2641: Move address known type to the confidential tab

* DFPL-2641: Refactor conversion tests, temp dupe function for others as incompatible due to UUIDs for firstOther

* DFPL-2641: Fix controller test

* DFPL-2641: Fix test - everyone was named James, clashing with new code...

* DFPL-2641: Fix test

* DFPL-2641: Fix test

* DFPL-2641: Fix test

* DFPL-2639: Move living situation (+ details) to the confidential tab (#5796)

Co-authored-by: prabhamuthu15 <78162288+prabhamuthu15@users.noreply.github.com>

---------

Co-authored-by: Alistair Osborne <alistair.osborne@justice.gov.uk>
Co-authored-by: prabhamuthu15 <praba.muthu@justice.gov.uk>
Co-authored-by: Daniel Catchpole <daniel.catchpole@justice.gov.uk>
Co-authored-by: prabhamuthu15 <78162288+prabhamuthu15@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants