Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating with for suggestions #273

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Updating with for suggestions #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6cc5f1
Updating with for suggestions
NikolaNaydenov Nov 14, 2019
4731a93
Need to escape the dot
NikolaNaydenov Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infrastructure/idam-preview.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ asp_rg_override = "idam-idam-preview"

capacity = 1

strategic_policies_privateIpsFilterPattern = ""
vnet_private_ip_pattern = "10\\.97\\.\\d+\\.\\d+"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversely, I think retaining the same name make it much easier to identify mistakes and issues in the marshalling of variables through the provisioning tasks.

@kremi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense and is a different way to look at it.

My thinking is it’s helpful to have the var name be meaningful in the current context. Having it as vnet private ip makes it easier for me to read and reason about in the context of infrastructure provisioning.

2 changes: 1 addition & 1 deletion infrastructure/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ module "idam-web-public" {

GA_TRACKING_ID = "${var.ga_tracking_id}"

STRATEGIC_POLICIES_PRIVATEIPSFILTERPATTERN = "${var.strategic_policies_privateIpsFilterPattern}"
STRATEGIC_POLICIES_PRIVATEIPSFILTERPATTERN = "${var.vnet_private_ip_pattern}"
}
}
4 changes: 2 additions & 2 deletions infrastructure/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ variable vault_name_override {
default = ""
}

variable "strategic_policies_privateIpsFilterPattern" {
description = "Private IPs Filter Pattern for Policies Evaluation"
variable "vnet_private_ip_pattern" {
description = "Private VNet IP Filter Pattern for Policies Evaluation"
default = "10\\.\\d+\\.\\d+\\.\\d+"
}