Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1-rc2 #379

Merged
merged 3 commits into from
Jun 10, 2020
Merged

v2.1-rc2 #379

merged 3 commits into from
Jun 10, 2020

Conversation

tbamido
Copy link
Contributor

@tbamido tbamido commented Jun 9, 2020

v2.1-rc2

Merge preview into master

DO NOT MERGE

Until we check all checkboxes below.

Change description

-[x] Increase code test coverage for Sonar. (#377)

  • avoid running functional tests twice in nightly build
  • Increase test code coverage

-[x] Cherry pick #378 once it's built and merged.

  • Remove unused terraform data reference to the cnp-idam-master project state.

-[x] Confirm all changes required for rc2 are in this branch

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

* Increase test code coverage.

* Increase test code coverage, pt.2.

* avoid running functional tests twice in nightly build

* Add missing assertions in a test.

Co-authored-by: Shravan Mechineni <shravan.mechineni@ladbrokescoral.com>
(cherry picked from commit 792d59d)
@tbamido tbamido self-assigned this Jun 9, 2020
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview June 9, 2020 15:44 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview June 9, 2020 16:25 Inactive
Douglas Brand-Williamson and others added 2 commits June 9, 2020 17:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview June 9, 2020 17:47 Inactive
@henrydobson henrydobson merged commit 72a500b into master Jun 10, 2020
@henrydobson henrydobson deleted the v2-1-rc2 branch June 10, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants