Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): make sandbox redis public for local dev #410

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

dougbw
Copy link
Contributor

@dougbw dougbw commented Jul 9, 2020

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/SIDM-4235

Change description

Make redis public for sandbox environment only to improve the local developer experience.

Build has completed here: https://sandbox-build.platform.hmcts.net/job/HMCTS_Sandbox_IDAM/job/idam-web-public/job/SIDM4235-sandbox-public-redis/2/

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 9, 2020 12:08 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 9, 2020 12:58 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 9, 2020 13:37 Inactive
Copy link
Contributor

@henrydobson henrydobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change is not required.

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 10, 2020 08:14 Inactive
Douglas Brand-Williamson and others added 2 commits July 10, 2020 15:56

Unverified

This user has not yet uploaded their public signing key.
Co-authored-by: Henry Dobson <henrydobson@me.com>

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 10, 2020 14:59 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.8% 90.8% Coverage
0.0% 0.0% Duplication

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview July 10, 2020 15:02 Inactive
@dougbw dougbw merged commit 9265ac9 into preview Jul 10, 2020
@dougbw dougbw deleted the SIDM4235-sandbox-public-redis branch July 10, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants