SIDM-4178 Fix reverse tabnabbing vulnerability. #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
nikola-naydenov-hmcts
approved these changes
Aug 19, 2020
henrydobson
approved these changes
Aug 19, 2020
shravanmechineni
approved these changes
Aug 19, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
pushed a commit
that referenced
this pull request
Aug 20, 2020
* SIDM-4413 SIDM-4414 SIDM-4416 Welsh translations for SSO messages. (#439) * SIDM-4178 Fix reverse tabnabbing vulnerability. (#441) Co-authored-by: Shravan Mechineni <shravanmechineni5@gmail.com> * SIDM-4641 sso feature flag (#440) * SIDM-4641 Disable SSO login button when the feature flag is off. * SIDM-4641 Unit test fix. * SIDM-4641 Make the SSO feature flag controlled by an env variable. * SIDM-4641 Rename the injected env variable. * Update src/main/resources/application.yaml Co-authored-by: tbamido <50667636+tbamido@users.noreply.github.com> Co-authored-by: tbamido <50667636+tbamido@users.noreply.github.com> * Ignore checked pa11y warnings. (#443) * Sidm 4178 zapscanner issues (#444) * SIDM-4178 Add base url tag to eliminate issues with relative URLs. * SIDM-4178 Add new interceptor rejecting TRACE and OPTIONS http method in conjunction with Max-Forwards http heder. * SIDM-4178 Add test code coverage. * SIDM-4178 Fix an issue with an incorrect password reset relative url. * SIDM-4178 Fix an issue with an incorrect user activation relative url + Sonar. Co-authored-by: Shravan Mechineni <shravanmechineni5@gmail.com> Co-authored-by: tbamido <50667636+tbamido@users.noreply.github.com> Co-authored-by: dfourn <daniel.patynski@amido.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.hmcts.net/jira/browse/SIDM-4178
Change description
Fix reverse tabnabbing vulnerability.
Does this PR introduce a breaking change? (check one with "x")