Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a feature flag controlling StepUp authentication. #518

Merged
merged 4 commits into from
Oct 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2020

Change description

Step up authn feature flag.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@@ -124,6 +124,7 @@ azure:

features:
federated-s-s-o: ${federated.sso:true}
step-up-authentication: ${step.up.authentication:true}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be true by default for functional tests. It can then be controlled by a flux entry.

@ghost ghost requested a review from kremi October 29, 2020 09:44
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview October 29, 2020 09:46 Inactive
@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview October 29, 2020 09:47 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

86.0% 86.0% Coverage
0.0% 0.0% Duplication

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview October 29, 2020 10:29 Inactive
@kremi kremi merged commit 6c005e7 into preview Oct 29, 2020
@kremi kremi deleted the StepUp-Authn-feature-flag branch October 29, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants