Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIDM-5175: Aligning the Verification code screen to the UX prototype #543

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

kremi
Copy link
Collaborator

@kremi kremi commented Nov 30, 2020

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/SIDM-5175

Change description

  • Make the code input shorter (fixed width, per prototype)
  • Make the text paragraph take up 2/3 of the screen estate (on normal screens)
  • Added Welsh translation as provided by the Welsh Team

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

</c:if>
<form:input
class="form-control${hasBindError? ' form-control-error' : ''}"
id="code" name="code" path="code" type="text" style="width:120px" value="" autocomplete="off"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a relative unit like em.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@jenkins-reform-hmcts jenkins-reform-hmcts temporarily deployed to preview November 30, 2020 15:46 Inactive
@kremi kremi merged commit 9bbf419 into preview Nov 30, 2020
@kremi kremi deleted the SIDM-5175-verification-screen-UX branch November 30, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants