Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDCC-2390: Delete API - Delete Users by Email Pattern or User ID #291

Merged
merged 40 commits into from
Apr 29, 2021
Merged

RDCC-2390: Delete API - Delete Users by Email Pattern or User ID #291

merged 40 commits into from
Apr 29, 2021

Conversation

AdilHMCTS
Copy link
Contributor

JIRA link (if applicable)

RDCC-2390

Change description

New Delete API to Delete (Functional Test) Users by Email Pattern or User ID

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

AdilHMCTS and others added 23 commits April 7, 2021 16:54
@AdilHMCTS
RDCC-2391: adding API & Swagger components to Controller
acc4d6d
@AdilHMCTS
RDCC-2390: adding Functional Tests
ccedac2
@AdilHMCTS
RDCC-2391: adding Integration Tests
728711a
@AdilHMCTS
RDCC-2390: adding CaseWorkerProfilesDeletionResponse class
de97293
@AdilHMCTS
RDCC-2390: adding service methods to interface
c64521e
@AdilHMCTS
RDCC-2390: adding implementation of new service methods
a4d5eb7
@AdilHMCTS
RDCC-2390: adding repository methods
3fbc18f
@AdilHMCTS
RDCC-2390: adding UP Delete APIs to UserProfileFeignClient
86985d9
@AdilHMCTS
RDCC-2390: adding deleteCaseWorkerProfileByIdOrEmailPattern method to…
70e5944 
… Controller
@AdilHMCTS
Merge branch 'master' of https://github.com/hmcts/rd-caseworker-ref-api…
4fc004f 
… into RDCC-2390

� Conflicts:
�	src/main/java/uk/gov/hmcts/reform/cwrdapi/repository/CaseWorkerProfileRepository.java
�	src/main/java/uk/gov/hmcts/reform/cwrdapi/service/impl/CaseWorkerServiceImpl.java
@AdilHMCTS
RDCC-2390: resolving merge conficts with Master
83d7da2
@AdilHMCTS
RDCC-2390: adding unit tests for CaseWorkerServiceImpl
0129eab
@AdilHMCTS
RDCC-2390: adding new API to FeatureToggleServiceImpl
8320a44
@AdilHMCTS
RDCC-2390: updating new API flag in CaseWorkerRefFunctionalTest
af761e5
@AdilHMCTS
RDCC-2390: adding unit tests for CaseWorkerProfileRepository
c95a2f0
@AdilHMCTS
RDCC-2390: pointing to UP PR containing new Delete API (to be reverted)
657c6aa
@AdilHMCTS
Merge branch 'master' into RDCC-2390
89c3fba
@AdilHMCTS
RDCC-2390: reverting FT application.yaml changes
7bd8a89
@AdilHMCTS
RDCC-2390: updating UP URL
69972b3
@AdilHMCTS
RDCC-2390: updating UserProfile Delete API in FeignClient
39bd1dd
@AdilHMCTS
RDCC-2390: creating Constant for Error Message
4d75068
@AdilHMCTS
RDCC-2390: changing to static import
d30b91e
@AdilHMCTS
Merge branch 'master' into RDCC-2390
a43c7ea
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 21, 2021 09:05 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 21, 2021 10:16 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 21, 2021 10:56 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 28, 2021 15:29 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 28, 2021 15:33 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 29, 2021 09:17 Inactive
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 29, 2021 09:51 Inactive
SujeethKumarAri
SujeethKumarAri suggested changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@SujeethKumarAri SujeethKumarAri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the changes, I shall approve once
"UP is being pointed to AAT again"

src/functionalTest/resources/application-functional.yaml Outdated Show resolved Hide resolved
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 12:24 Abandoned
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 12:31 Abandoned
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 12:47 Abandoned
@AdilHMCTS AdilHMCTS closed this Apr 29, 2021
@AdilHMCTS AdilHMCTS reopened this Apr 29, 2021
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 13:08 Abandoned
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 13:19 Abandoned
@hmcts-jenkins-rd hmcts-jenkins-rd bot requested a deployment to preview April 29, 2021 13:28 Abandoned
@hmcts-jenkins-rd hmcts-jenkins-rd bot temporarily deployed to preview April 29, 2021 13:51 Inactive
@AdilHMCTS AdilHMCTS merged commit 03d87a2 into master Apr 29, 2021
@AdilHMCTS AdilHMCTS deleted the RDCC-2390 branch April 29, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijitdiwan abhijitdiwan abhijitdiwan left review comments

@kavithagade12 kavithagade12 kavithagade12 approved these changes

@SujeethKumarAri SujeethKumarAri SujeethKumarAri approved these changes

@shreedhar-hmcts shreedhar-hmcts shreedhar-hmcts approved these changes

@nitishsingla1234 nitishsingla1234 nitishsingla1234 left review comments

Assignees
No one assigned
Labels
ns:rd prd:rd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdilHMCTS @nitishsingla1234 @abhijitdiwan @shreedhar-hmcts @SujeethKumarAri @kavithagade12