Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate spring-batch tables #878

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Recreate spring-batch tables #878

merged 2 commits into from
Dec 4, 2024

Conversation

lukasz-wolski
Copy link
Contributor

Change description

Migration script to rename existing spring-batch tables

  • allows spring-batch to recreate its tables based on new module version

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

recreates spring-batch tables and sequences
Copy link
Contributor

@kiran-yenigala-hmcts kiran-yenigala-hmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed can you adjust so the script matches the original V1_29__spring-batch-schema-recreate.sql except with _Archive2 and _A2. (i.e. so the script leaves the earlier Archive tables alone - and moves current tables sstraight to A2: this would allow any future Archive3 to be created in the same way without having to restructire 1 & 2 etc). Many thanks

Copy link

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@lukasz-wolski lukasz-wolski merged commit aff103a into master Dec 4, 2024
5 checks passed
@lukasz-wolski lukasz-wolski deleted the lukasz-wolski-patch-2 branch December 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants