Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated sscs-common version #4231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benouaer
Copy link
Contributor

Jira link

Change description

  • retain addressLine3 in java code

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@benouaer benouaer requested a review from a team as a code owner December 13, 2024 15:35
Copy link

CCD diff report

No change

Copy link

github-actions bot commented Dec 13, 2024

Integration Tests results

   82 files  ±0     82 suites  ±0   9m 11s ⏱️ -5s
1 424 tests ±0  1 416 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 425 runs  ±0  1 417 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6ccb74c. ± Comparison against base commit 2626386.

This pull request removes 14 and adds 14 tests. Note that renamed tests count towards both.
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=granted, date=2024-12-13]) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=refused, date=2024-12-13]) [1]
…
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=granted, date=2024-12-16]) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=refused, date=2024-12-16]) [1]
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants