Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSCSCI-1493 #4288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SSCSCI-1493 #4288

wants to merge 4 commits into from

Conversation

nilay913
Copy link
Contributor

Jira link

See SSCSCI-1493

Change description

updating PO box addresses for IBC cases for notifications and letters

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@nilay913 nilay913 requested a review from a team as a code owner January 13, 2025 10:04
@github-actions GitHub Actions
Copy link

CCD diff report

No change

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Integration Tests results

   82 files  ±0     82 suites  ±0   9m 25s ⏱️ +14s
1 425 tests ±0  1 417 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 426 runs  ±0  1 418 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ed7ca72. ± Comparison against base commit 97c63e1.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both. 
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [0]

uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [3]

♻️ This comment has been updated with latest results.

benouaer
benouaer reviewed Jan 16, 2025
View reviewed changes
src/main/resources/config/application.yaml
@@ -1931,6 +1934,9 @@ exela:
addressPostcode: CM20 9QF
scottishAddressLine2: PO BOX 13150
scottishPostcode: CM20 9TT
ibcAddressLine1: HMCTS Infected Blood Compensation Appeals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the same properties since it's the same value?

benouaer
benouaer reviewed Jan 16, 2025
View reviewed changes
...java/uk/gov/hmcts/reform/sscs/evidenceshare/service/placeholders/PlaceholderServiceTest.java
given(exelaAddressConfig.getAddressLine1()).willReturn("Line 1");
given(exelaAddressConfig.getAddressLine2()).willReturn("Line 2");
given(exelaAddressConfig.getAddressLine3()).willReturn("Line 3");
given(exelaAddressConfig.getAddressPostcode()).willReturn("Postcode");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could put these 4 mocks in a method to reduce repetition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benouaer benouaer benouaer approved these changes

Assignees
No one assigned
Labels
enable_keep_helm ns:sscs prd:sscs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilay913 @benouaer