Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of "prop drilling" #46

Merged
merged 9 commits into from
Dec 17, 2023
Merged

Reduce amount of "prop drilling" #46

merged 9 commits into from
Dec 17, 2023

Conversation

hmellor
Copy link
Owner

@hmellor hmellor commented Dec 17, 2023

No description provided.

@hmellor hmellor mentioned this pull request Dec 17, 2023
Closed
8 tasks
@hmellor hmellor changed the title Use Context for item state Reduce amount of "prop drilling" Dec 17, 2023
@hmellor hmellor merged commit 3d2e989 into react Dec 17, 2023
@hmellor hmellor deleted the reduce-prop-drilling branch December 17, 2023 18:22
hmellor added a commit that referenced this pull request Dec 18, 2023
* Initial commit

* Consolidate duplicated money formatting code (#43)

* Ensure feature parity between new `Modal`s and old `popups.js` (#44)

* Add empty admin page (#45)

* Fix Item subtitle

* Revert changing of intentional typo

* Reduce amount of "prop drilling" (#46)

* Use `Context` for item state

* `ItemProvider.js` -> `ItemsProvider.js`

* Use `Context` for modal state

* Remove some unused imports

* Disable submit bit button in info modal if item ended

* Remove unused argument from HomePage

* Add content to admin page (#48)

* Fix GitHub icon in Footer

* Fix some warnings & some small tweaks

* Add table and action buttons to admin page

* Move images (not final location)

* Delete last of old JS

* Edit `items.yml` formatting

* Delete unused `admin.html`

* Correct package name

* Add concurrency fix

* Fix warning

* Fix name and version

* Change concurrency condition

* Update action versions

* Fix workflow

* New workflow

* Maybe fix

* Fix dependency

* Correct build dir

* Fix homepage

* Move images

* Relative homepage

* Try removing homepage

* Fix missing dependency

* Change all paths until better solution found

* Make homepage usable by others

* Rename workflow file and update readme

* Change action to run on push to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant