Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds with GitHub actions #251

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Builds with GitHub actions #251

merged 4 commits into from
Jul 21, 2020

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 19, 2020

Hello,

I discovered this book a couple of weeks ago and I learned a lot from it so I wanted to bring my stone to the building.

The idea that I had in mind was an easy way for everyone to see the result of each new change, without the hassle of building PDFs, without the hassle of using docker and/or having LaTeX installed locally.

This PR:

  • Provide a Github Action workflow that builds all the PDF versions;
  • Create a github pre-release for each commit and upload the generated PDF assets;
  • Add missing required fonts in src/fonts;
  • Provide the generated PDF as build artifacts

You can find the outcome of this on my fork: https://github.com/drupol/milewski-ctfp-pdf/actions/runs/175561730
And the automatic pre-release that was created with all the assets uploaded: https://github.com/drupol/milewski-ctfp-pdf/releases/tag/8bb1afd

Edit: I made a first version, the building time was 50 min, then an updated version where I'm down to 14 min by running concurrent builds. I'm pretty sure there are ways to improve this.

@hmemcpy
Copy link
Owner

hmemcpy commented Jul 20, 2020

This is amazing, thanks so much for doing this! I'll have a look tonight and will merge it ASAP!

@drupol
Copy link
Collaborator Author

drupol commented Jul 20, 2020

This is amazing, thanks so much for doing this! I'll have a look tonight and will merge it ASAP!

Thanks :-)

@drupol drupol marked this pull request as ready for review July 20, 2020 10:51
@hmemcpy hmemcpy merged commit 3832e56 into hmemcpy:master Jul 21, 2020
@hmemcpy
Copy link
Owner

hmemcpy commented Jul 21, 2020

Thank you again for the effort! I'll have it set up and hopefully working soon!

@drupol drupol deleted the builds-with-github-actions branch July 21, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants