Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HollowCone fix #4

Closed
wants to merge 11 commits into from
Closed

HollowCone fix #4

wants to merge 11 commits into from

Conversation

jngrad
Copy link

@jngrad jngrad commented Aug 25, 2018

Fixes espressomd/espresso/#2129

Applied a fix by @RudolfWeeber and corrected the cone orientation in the tutorial.

Note: during the tutorial simulation exercise, output files *.dat and *.vtk store the negative of the particle velocities, such that the curves of Figure 6 are flipped on the Y-axis when plotted in a spreadsheet software and the velocity arrows point in the opposite direction in ParaView.

@RudolfWeeber
Copy link

RudolfWeeber commented Aug 26, 2018 via email

@mkuron
Copy link
Collaborator

mkuron commented Aug 27, 2018

@jngrad needs to merge jngrad#1, then @hmenke needs to merge the present pull request (#4). @hmenke then needs to resolve a bunch of merge conflicts and apply the style changes suggested by clang-format. Then espressomd#2129 can be merged.

@hmenke hmenke closed this Apr 14, 2019
@jngrad jngrad deleted the hollowcone-sign branch August 31, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants