Arabic toponym checks #349
Conversation
locations.xml
Outdated
| @@ -15363,7 +15363,7 @@ | |||
| </GameIds> | |||
| <Names> | |||
| <Name language="Alemannic" value="Die autonomi Gmäinschaft Aragonie" /> | |||
| <Name language="Arabic" value="Araghún" /> | |||
| <Name language="Arabic" value="Saraqusṭaẗ" comment="There only exists Taifa (Duchy) of Saraqusṭaẗ in history, if Aragon is preferable, use 'Araġūn'" /> | |||
There was a problem hiding this comment.
I would stick with Araġūn since the title is *_aragon. I generally try to just stick to names and refrain from fixing the game's inaccuracies, as that can be done through separate mods
locations.xml
Outdated
| @@ -156264,6 +156264,7 @@ | |||
| <LocationId>badajoz</LocationId> | |||
| </FallbackLocations> | |||
| <Names> | |||
| <Name language="Arabic" value="Baṭalyūs" comment="Based on the name of Taifa(?)" /> | |||
There was a problem hiding this comment.
This should be placed under badajoz. This location (lusitania) already inherits names from badajoz when its own are not available - which is just the case for Arabic.
Also, badajoz already has an Arabic name "Baṭalyaws", you can just update that one instead, as yours has the correct diacritics.
There was a problem hiding this comment.
BTW: The locations from which the names are inherited are defined under <FallbackLocations></FallbackLocations>
locations.xml
Outdated
| @@ -318029,6 +318031,7 @@ | |||
| <LocationId>lleida</LocationId> | |||
| </FallbackLocations> | |||
| <Names> | |||
| <Name language="Arabic" value="Lāridaẗ" /> | |||
There was a problem hiding this comment.
I think this should be under location lleida, which this location (lleida_region) already inherits names from.
Unless it's a different form specific to the region of Lleida, in which case it's fine to have it here.
locations.xml
Outdated
| @@ -318999,6 +319002,7 @@ | |||
| <LocationId>coruna</LocationId> | |||
| </FallbackLocations> | |||
| <Names> | |||
| <Name language="Arabic" value="Qarǧiṭaẗ" comment="found in 4118Htm" /> | |||
There was a problem hiding this comment.
This location (coruna_county) already inherits names from location coruna, so no need to define it in both places. If it's used for Coruña generically, put it under coruna, if it's specific to just the county/region, put it under coruna_county.
|
Hello. Thanks, it was a pleasure! I really need to familiarize myself with the code structure more. A question since I'm new to this. What will happen if I click the "Resolve conversation" button below each comments? I do think I should make a new commit, but I also think those above are like "revision approval" sections? Which one is correct? EDIT: Nvm, I get it now. |
This is my first pr, I might need a hand if there's any mistake.