PLATUI-1550: fix hmrc-header mobile dropdown behaviour #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken for any service using hmrc-frontend with a version of govuk-frontend after version 3 where they changed the code that initialises the behaviour of govuk-header (which hmrc-header depends on) to require data-module attributes to use a "govuk-" prefix
Fix was to add the prefix to the data-module attribute. I've done some searching and it seems like there are possibly only two services using navigation items with the hmrcHeader (at least via play-frontend-hmrc) so it might be that's why this bug managed to go undetected for a while, because few hmrc services were using the navigation items in the hmrcHeader.
I've added a visual regression test to catch any issues with this in the future.
Did a search for other uses of data-module attributes that could have been missed and nothing came up: