⛔️ DO NOT MERGE ⛔️ stop using deprecated 14px typography style in account menu and it's notification badge #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One I could fix, the others we need to suppress - and the reasons have been added as comments inline - off the back of this we need to talk with pta and design resources about change needed to pta-account-menu
DO NOT MERGE This is an example to use to discuss the impact of change / what we should do about it with PTA and Design Resources - as it might need some coordination and the actual change might be different - or contain additional tweaks to make new font size fit (at the least) alphagov/govuk-design-system#2289
Base automatically changed from
PLATUI-3037-suppress-prototype-warnings-for-hmrc-styles
to
main
June 5, 2024 15:33
|
copying a summary from some initial slack discussion, sounds like maybe rather than going to 16px and then having a change to coordinate across lots of services, we might just inline the current behaviour at 14px so that we aren't impacted by the deprecation, then not worry about maintainability of that because the new navigation patterns from gov.uk are on the horizon and likely we'd be better investing time in rolling that out when it's available rather than updating this pattern |
|
we have now inlined the compiled css for this, so we aren't impacted by the deprecation- and eventually this menu will be replaced by new service navigation component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ DO NOT MERGE ⛔️
This is an example to use to discuss the impact of change / what we should do about it with PTA and Design Resources - as it might need some coordination and the actual change might be different - or contain additional tweaks to make new font size fit (at the least)
alphagov/govuk-design-system#2289