Enhance GA tracking consent check #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPeck
approved these changes
Oct 2, 2024
JamesPeck
approved these changes
Oct 2, 2024
Consolidate Google Analytics, Tag Manager, and Consent functionalities into a single component for better maintainability. This change removes the individual components for each functionality and integrates them into a unified `GoogleTracking.svelte` component. Updated the layout to only include the new component and adjusted the tests accordingly to reflect the new consent properties.
Gcolon021
force-pushed
the
Google-Consent-Fix
branch
from
6cbfd68
to
9516f80
Compare
JamesPeck
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ALS-6742] FIX: Google Consents
security_storageand replaced it withad_user_data.GoogleTracking.svelteclass. This made it easier to ensure things are loaded in the expected order and to maintain the code.