[ALS-7330][ALS-7329] RAS login and logout button #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced Okta RAS support with enhanced authentication flow and proper token management. Improved logout handling to accommodate different authentication providers, ensuring users are redirected appropriately after logout. Also included minor modifications to UI components and cleanup of unnecessary logs.
Expanded configuration for Researcher Auth Service (RAS) in the .env.test file to include additional parameters such as Okta IDP ID, connection type, image source, and logout URIs. This update ensures better integration and functionality for the RAS authentication module.
Gcolon021
commented
Oct 10, 2024
JamesPeck
reviewed
Oct 10, 2024
Removed unnecessary awaits in logout and ensured required fields are validated in the RAS constructor. Improved consistency in the CSS for the login button image.
Updated variable names related to logout URIs for consistency across AuthProvider and RAS classes. Changes include renaming sessionLogoutURI to logouturl and oktalogoutredirect to oktalogouturl, and updating related environment variables.
JamesPeck
approved these changes
Oct 10, 2024
Added console error logging to identify missing providers and detailed debug statements for failed RAS authentication. This will aid in easier troubleshooting of authentication-related problems.
Previously, the state was generated anew for each instance, but now it retrieves the state from localStorage or generates and stores a new one if not found. This change ensures consistency across sessions.
JamesPeck
pushed a commit
that referenced
this pull request
Oct 11, 2024
[ALS-7330][ALS-7329] RAS login and logout button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ALS-7330][ALS-7329] RAS login and logout button