Remove threads.js #160
Merged
Remove threads.js #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
approved these changes
Apr 23, 2020
src/loaders/index.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| import { openArray } from 'zarr'; | |||
| // eslint-disable-next-line import/extensions | |||
| function decode(self, fileDirectory, buffer) { | ||
| const decoder = getTiffDecoder(fileDirectory); | ||
| const result = decoder.decode(fileDirectory, buffer); | ||
| self.postMessage([result], [result]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoTIFF recently ventured into threads.js which made bundling this application very difficult unless we tell upstream users to carry a plugin, which I think is not ideal.
We now re-use the old WebWorker code from GeoTIFF that they had and bundle it directly as an inline web worker. I'll open an issue with them to see if they want to go back to this.
This also inadvertently fixes #97 . See andywer/threads.js#211 for someone experiencing a similar issue and andywer/threads.js#232 (comment) for the GeoTIFF contributor getting feedback.