Some minor cleanups on Unix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbrubeck
commented
Jan 24, 2017
mbrubeck
commented
- Build winapi crates on Windows only
- Fix an unused import warning
hniksic
requested changes
Jan 24, 2017
| @@ -607,7 +607,6 @@ mod os { | |||
| use std::ffi::OsString; | |||
| use std::time::{Duration, Instant}; | |||
|
|
|||
| use super::ChildState::*; | |||
There was a problem hiding this comment.
Unfortunately, omitting this line prevents successful compilation with Rust 1.14.0 (stable). This is visible in the Travis CI log.
There was a problem hiding this comment.
Oh, I see. I guess this changed in Rust 1.15 because of rust-lang/rust#35120. I have removed this change from the PR.
|
Merged, thanks for the patch. Maybe we could avoid a spurious warning on 1.15.x with a #![cfg(...)] guard? I'm not sure if that's standard practice in Rust, but it's a small price to pay for a warningless compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.