This repository was archived by the owner on May 14, 2019. It is now read-only.
getBoundingClientRect() incorrectly reports width for hidden containers #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to use minigrid on hidden container e.g. Bootstrap navbar menu items. Firstly you have to set display to initial and reset back
|
There is another problem in Internet Explorer 11. Just change display = 'initial' to display = 'block' |
|
Thanks @insekticid! Going to review it and update tonight 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to use minigrid on hidden container e.g. Bootstrap navbar menu items. Firstly you have to set display to initial, calculate width and height and then reset back