Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetShipmentList: Value "2019-11-11T08:35:19.547+01:00" is not a valid ISO 8601 format. #19

Closed
DangerLifter opened this issue Nov 11, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DangerLifter
Copy link

I suppose It makes sense support that date time format in all API methods.

`In Assertion.php line 2752:

[Assert\InvalidArgumentException (214)]
Value "2019-11-11T08:35:19.547+01:00" is not a valid ISO 8601 format.

Exception trace:
() at /var/www/projects/bol.com-app/vendor/beberlei/assert/lib/Assert/Assertion.php:2752
Assert\Assertion::createException() at /var/www/projects/bol.com-app/vendor/beberlei/assert/lib/Assert/Assertion.php:2403
Assert\Assertion::date() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Model/DateTime.php:17
BolCom\RetailerApi\Model\DateTime->__construct() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Model/DateTime.php:31
BolCom\RetailerApi\Model\DateTime::fromString() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Model/Shipment/ShipmentListItem.php:111
BolCom\RetailerApi\Model\Shipment\ShipmentListItem::fromArray() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Model/Shipment/ShipmentList.php:53
BolCom\RetailerApi\Model\Shipment\ShipmentList::fromArray() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Handler/Shipment/GetShipmentListHandler.php:54
BolCom\RetailerApi\Handler\Shipment\GetShipmentListHandler->__invoke() at /var/www/projects/bol.com-app/vendor/bol-com/retailer-api/src/Infrastructure/MessageBus.php:111
`

@JeroenVanLeusden JeroenVanLeusden self-assigned this Nov 11, 2019
@JeroenVanLeusden JeroenVanLeusden added the bug Something isn't working label Nov 11, 2019
@DangerLifter DangerLifter changed the title GeShiomentList: Value "2019-11-11T08:35:19.547+01:00" is not a valid ISO 8601 format. GetShipmentList: Value "2019-11-11T08:35:19.547+01:00" is not a valid ISO 8601 format. Nov 11, 2019
@JeroenVanLeusden
Copy link

@DangerLifter I've contacted bol.com for this because they claim to use SO 8601 but clearly they're not consistently. For now i've converted the date to SO 8601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants