Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

WITH_COMPOSER constant: Make a difference between "downloaded with composer" and "autoloaded with composer" #12

Open
@ulk200

Description

@ulk200

This is related to hoaproject/Ruler#86
I'm using the Hoa/Ruler library that i downloded with composer, but i'm using a third party autoloader. When hoa://Library/Ruler/Grammar.pp gets loaded the \Hoa\Protocol\Node\Library object calls its parent in the reach function because the WITH_COMPOSER contant is false. effectivly looking into directories in a camelcase name format.
But since i used composer to download the files, Grammar.pp is not found (my directories are not camelcase)
I solved this by forcing WITH_COMPOSER to true, this constant is based on wether the Composer\Autoload\ClassLoader class exists or not.
It may be preferable to make a distinction between "downloaded with composer" (which sets a specific directory structure) from the "autoloaded_with_composer" (which imply the class present at runtime).
Then hoa://Library/Ruler/Grammar.pp should rely on the "downloaded with composer" constant to call its parent or not.
Thank you.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions