Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes installation with Kustomize #324

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

j-fuentes
Copy link
Contributor

This PR adds sample manifests for a Kubernetes installation using Kustomize.

I tried to reduce it to the basics, aiming to make it as similar as possible to the docker-compose one.

It should be pretty easy to extend to specific environments.

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you so much!

Looks good to me! We can merge after addressing the amd64 discussion.

Note: This can get much simpler after the next hoarder release. We'll get rid of the redis dependency, and we're doing an All-in-One container to get rid of the workers container as well.


### Requirements

- A kubernetes cluster with at least a amd64 node.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why do you need a single amd64? Hoarder (and all of its dependencies) work on arm as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My cluster has a mix of amd64 and arm64 nodes. When I tried it, I was having issues with the chromium container. It could run but there was an error. I did not copy the error but I tried to run it on amd64 and everything worked.

So I have been a bit lazy not getting to the button of the issues.

But if everything is supposed to be arm64 compatible we can remove that restriction. I will update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 1b7ebf7

@@ -0,0 +1,50 @@
apiVersion: apps/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above. Why do we need to pin all the containers to amd64 nodes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered above.

@MohamedBassem MohamedBassem merged commit 7ddfcad into hoarder-app:main Jul 29, 2024
@MohamedBassem
Copy link
Collaborator

Thank you!

@j-fuentes j-fuentes deleted the kustomize branch July 30, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants