Clear disabled signups message #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedBassem
requested changes
Sep 14, 2024
| @@ -208,7 +207,6 @@ function SignUp() { | |||
| <ActionButton | |||
| type="submit" | |||
| loading={form.formState.isSubmitting} | |||
| disabled={clientConfig.auth.disableSignups} | |||
| > | |||
| Sign Up | |||
There was a problem hiding this comment.
How about we just do the change in the text directly here?:
Suggested change
| Sign Up | |
| {clientConfig.auth.disableSignups ? "Signups are currently disabled" : "Sign Up"} |
There was a problem hiding this comment.
Hiding the whole signup form or tab would be much clearer, I don't think we need the form shown if it serve no purposes other than confusing users.
There was a problem hiding this comment.
I agree, this also confused me when i had that set for testing purposes. If signup is disabled, I don't expect to see a signup page
There was a problem hiding this comment.
Ok, in that case I don't mind.
|
Thanks a lot @nghduc97 and welcome to the contributor lists! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior to disable only the button when
DISABLE_SIGNUPS=trueis really easy to misunderstood #52