Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the thumbnail image keeping its real ratio instead of object-cover like Pinterest layout #540

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Made the thumbnail image keeping its real ratio instead of object-cover like Pinterest layout #540

wants to merge 4 commits into from

Conversation

echo-saurav
Copy link

Screenshot 2024-10-15 at 9 32 53 PM

@kamtschatka
Copy link
Collaborator

one thing that recently happend was that those kinds of images get too big if you have full page screenshots active. In one of those cases the image height was 47000 px (or 7,6MB), so there definitely needs to be some kind of limit^^
See my PR, where I limited the max height to 1000px: #526

fyi: There is already an issue about this exact problem (#261), where we agreed that this needs fixing, so thanks for picking this up, but it needs some refinement.

@echo-saurav
Copy link
Author

So i have change the max height to max-h-screen , i guess its enough ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echo-saurav @kamtschatka