Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment header modal #156

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Uncomment header modal #156

merged 2 commits into from
Mar 3, 2023

Conversation

devpro
Copy link
Contributor

@devpro devpro commented Mar 1, 2023

What this PR does / why we need it

Header modals cannot be displayed anymore. A user is unable to see the About page and cannot logout.

Which issue(s) this PR fixes

  • Uncomment the header modal that was commented in PR Add cloud-init & Webservices to Admin-UI #149
  • Minor update to CI pipeline to use latest version of checkout action and explicitly fix the Node.js version (and fix typo in comment)

@jggoebel jggoebel merged commit ac44718 into hobbyfarm:master Mar 3, 2023
@devpro devpro deleted the feature/fix-header-modal branch March 3, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devpro @jggoebel