Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NewIndex() to ease testing #142

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Refactor NewIndex() to ease testing #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions pkg/rbacclient/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@ package rbacclient
import (
"fmt"
v1 "k8s.io/api/rbac/v1"
"k8s.io/client-go/informers"
v12 "k8s.io/client-go/informers/rbac/v1"
"k8s.io/client-go/tools/cache"
)

const (
rbIndex = "rbac.hobbyfarm.io/rb-index"
rbIndex = "rbac.hobbyfarm.io/rb-index"
RbacGroup = "rbac.authorization.k8s.io"
All = "*"
APIGroup = "hobbyfarm.io"
All = "*"
APIGroup = "hobbyfarm.io"
)

var (
KindUser = "User"
KindGroup = "Group"
KindUser = "User"
KindGroup = "Group"
KindServiceAccount = "ServiceAccount"
)

Expand All @@ -25,42 +25,44 @@ type Index struct {

namespace string

roleBindingIndexer cache.Indexer
roleBindingIndexer cache.Indexer
clusterRoleBindingIndexer cache.Indexer

roleIndexer cache.Indexer
roleIndexer cache.Indexer
clusterRoleIndexer cache.Indexer
}

func NewIndex(kind string, namespace string, informerFactory informers.SharedInformerFactory) (*Index, error) {
func NewIndex(
kind string,
namespace string,
rbInformer v12.RoleBindingInformer,
crbInformer v12.ClusterRoleBindingInformer,
rInformer v12.RoleInformer,
crInformer v12.ClusterRoleInformer) (*Index, error) {
i := &Index{
kind: kind,
kind: kind,
namespace: namespace,
}

// build an informer for each of rolebinding and clusterrolebinding
rbInformer := informerFactory.Rbac().V1().RoleBindings().Informer()
crbInformer := informerFactory.Rbac().V1().ClusterRoleBindings().Informer()

// add the indexers to a map...
rbIndexers := map[string]cache.IndexFunc{rbIndex + "-" + kind: i.roleBindingSubjectIndexer}
crbIndexers := map[string]cache.IndexFunc{rbIndex + "-" + kind: i.clusterRoleBindingSubjectIndexer}

// ... then tell the informers to use those indexers
if err := rbInformer.AddIndexers(rbIndexers); err != nil {
if err := rbInformer.Informer().AddIndexers(rbIndexers); err != nil {
return nil, err
}

if err := crbInformer.AddIndexers(crbIndexers); err != nil {
if err := crbInformer.Informer().AddIndexers(crbIndexers); err != nil {
return nil, err
}

// finally, generate the indexers and store in the index struct
i.roleBindingIndexer = rbInformer.GetIndexer()
i.clusterRoleBindingIndexer = crbInformer.GetIndexer()
i.roleBindingIndexer = rbInformer.Informer().GetIndexer()
i.clusterRoleBindingIndexer = crbInformer.Informer().GetIndexer()

i.roleIndexer = informerFactory.Rbac().V1().Roles().Informer().GetIndexer()
i.clusterRoleIndexer = informerFactory.Rbac().V1().ClusterRoles().Informer().GetIndexer()
i.roleIndexer = rInformer.Informer().GetIndexer()
i.clusterRoleIndexer = crInformer.Informer().GetIndexer()

return i, nil
}
Expand All @@ -72,7 +74,7 @@ if the index type (i.kind) is user, we index user subjects of rolebindings. if g
for both types, we index serviceaccounts as well as they are special

this lets us perform quick lookups of the rolebindings for a subject
*/
*/
func (i *Index) roleBindingSubjectIndexer(obj interface{}) (result []string, err error) {
rb, ok := obj.(*v1.RoleBinding)
if !ok {
Expand All @@ -97,7 +99,7 @@ if the index type (i.kind) is user, we index user subjects of clusterrolebinding
for both types, we index serviceaccounts as well as they are special

this lets us perform quick lookups of the clusterrolebindings for a subject
*/
*/
func (i *Index) clusterRoleBindingSubjectIndexer(obj interface{}) (result []string, err error) {
crb, ok := obj.(*v1.ClusterRoleBinding)
if !ok {
Expand Down
20 changes: 12 additions & 8 deletions pkg/rbacclient/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,37 @@ import (
)

const (
VerbList = "list"
VerbGet = "get"
VerbList = "list"
VerbGet = "get"
VerbCreate = "create"
VerbUpdate = "update"
VerbDelete = "delete"
VerbWatch = "watch"
VerbWatch = "watch"
)

type Client struct {
userIndex *Index
userIndex *Index
groupIndex *Index
}

func NewRbacClient(namespace string, kubeInformerFactory informers.SharedInformerFactory) (*Client, error) {
userIndex, err := NewIndex("User", namespace, kubeInformerFactory)
rbInformer := kubeInformerFactory.Rbac().V1().RoleBindings()
crbInformer := kubeInformerFactory.Rbac().V1().ClusterRoleBindings()
rInformer := kubeInformerFactory.Rbac().V1().Roles()
crInformer := kubeInformerFactory.Rbac().V1().ClusterRoles()

userIndex, err := NewIndex("User", namespace, rbInformer, crbInformer, rInformer, crInformer)
if err != nil {
return nil, err
}

groupIndex, err := NewIndex("Group", namespace, kubeInformerFactory)
groupIndex, err := NewIndex("Group", namespace, rbInformer, crbInformer, rInformer, crInformer)
if err != nil {
return nil, err
}

return &Client{
userIndex: userIndex,
userIndex: userIndex,
groupIndex: groupIndex,
}, nil
}
Expand All @@ -52,4 +57,3 @@ func (rs *Client) GetAccessSet(user string) (*AccessSet, error) {
func (rs *Client) GetHobbyfarmRoleBindings(user string) ([]*rbacv1.RoleBinding, error) {
return rs.userIndex.getRoleBindings(user)
}