Unit testing for RBAC client #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial unit tests for the rbacclient portion of Gargantua.
This is necessary as soon work will begin to add functionality to this area, and we'd like to not disturb anything :)
Mostly these tests verify that an rbac client can be created, that roles, bindings, and their cluster equivalents can be created and cached.
The tests also ensure at a basic level that RBAC decisions are made correctly (e.g. allowed vs disallowed).
This can probably be enhanced in many ways but it serves as a decent start.