Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings #146

Merged
merged 48 commits into from
Jun 20, 2023
Merged

Settings #146

merged 48 commits into from
Jun 20, 2023

Conversation

ebauman
Copy link
Member

@ebauman ebauman commented Jun 1, 2023

This PR adds support for Settings in HobbyFarm. Settings can be used for things like user preferences (e.g. dark mode), global settings (e.g. registration disabled)
This also lays the groundwork for upcoming 3rd party integrations that can leverage settings to integrate w/ HobbyFarm

  • setting type, generated clients
  • added CRD, settingserver
  • updated settings, re-gen'ed clients
  • more work
  • dot escaping, jsonPath for setting
  • Changed to using new kube_codegen.sh as recommended by upstream
  • regenerated code
  • added setting and property to gargantua
  • missed generated code?
  • changed Id to Name
  • register setting, list in scheme
  • fixed some json handling
  • fixed up some validation
  • validation webhook
  • moved servicereference to outside package
  • fixed up handling
  • validating webhook handling
  • type conversion error
  • version bumps for CVEs, features
  • moved deserializer codec out

What this PR does / why we need it:

Which issue(s) this PR fixes:

ebauman added 20 commits April 10, 2023 14:54
@ebauman
setting type, generated clients
3988b9b 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
added CRD, settingserver
4507313 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
updated settings, re-gen'ed clients
5740eed 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
more work
6fce9e5
@ebauman
dot escaping, jsonPath for setting
f721fa9
@ebauman
Changed to using new kube_codegen.sh as recommended by upstream
3846c55 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
regenerated code
1bc982f 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
added setting and property to gargantua
3a5d608 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
missed generated code?
3b7438b 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
changed Id to Name
d74dbcc 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
register setting, list in scheme
d7d68ff 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
fixed some json handling
a553d3c 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
fixed up some validation
869ab6d 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
validation webhook
5e61cde 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
moved servicereference to outside package
c7d9b63 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
fixed up handling
ab0011a 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
validating webhook handling
b4490f6 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
type conversion error
ca84df1 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
version bumps for CVEs, features
e430c29 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
moved deserializer codec out
6523aba 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
use label const
53fee4f 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
jggoebel
jggoebel reviewed Jun 8, 2023
View reviewed changes
pkg/property/validation.go Outdated
var ok = false
for _, e := range enum {
if value == e {
ok = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early break possible

ebauman added 11 commits June 12, 2023 12:52
@ebauman
public scope settings are.. public.
f850e61 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
Revert "Revert "beginning work on scope crd""
7cc8dc6 
This reverts commit d7e62dd.
@ebauman
regenerated clients incl new scope resource
c83402e 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
added list scopes endpoint
9bc0d0d 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
more clientgen stuff
0f3f319 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
reorganized validation and added scope checking
85d98e2 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
use hfclient and not kclient
3228770 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
missing some scope files from clientgen
78860f2 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
removing unused _ cuz goland told me to
3a2c97a 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
added CRD for scopes
d5de598 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
name, not namespace!
e75fefa 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
Copy link
Member Author

ebauman commented Jun 12, 2023

This can be tried live via ebauman/gargantua:12june2023

@jggoebel jggoebel mentioned this pull request Jun 13, 2023
Merged
jggoebel
jggoebel reviewed Jun 13, 2023
View reviewed changes
pkg/crd/crd.go Outdated
@@ -148,6 +156,43 @@ func GenerateCRDs(caBundle string, reference apiextv1.ServiceReference) []crder.
IsNamespaced(true).
AddVersion("v1", &v1.DynamicBindConfiguration{}, nil)
}),
hobbyfarmCRD(&v1.Scope{}, func(c *crder.CRD) {
c.IsNamespaced(true).AddVersion("v1", &v1.Scope{}, func(cv *crder.Version) {
cv.WithColumn("Name", ".displayName").IsServed(true).IsStored(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would rename this column to "Display Name", otherwise it can be confused with the default column "Name" that prints the metadata.name

Same for the Setting CRD

ebauman added 10 commits June 13, 2023 10:14
@ebauman
remove quotes from string scalars
95978f3 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
preinstall of settings and scopes
8596b0d 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
continue instead of return
f7e7829 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
internal setting client
5260a5c 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
register scope, scopelist into schema
ea305e3 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
settingclient startup, preinstall resources
88a97d8 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
formatting fix
8fcbed0 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
added checking for disabled registration
0ca099d 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
cleaned up loop logic
91cbe55 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman
proper naming of displayname columns
6d50219 
Signed-off-by: Eamon Bauman <eamon@eamonbauman.com>
@ebauman ebauman merged commit 148a910 into hobbyfarm:master Jun 20, 2023
@jggoebel jggoebel mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jggoebel jggoebel jggoebel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebauman @jggoebel