Better labeling for 3rd party provisioners #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, HobbyFarm requires that for any 3rd party provisioner (e.g. not internal terraform), that the environment be labeled with
hobbyfarm.io/provisioner=external
This forces all 3rd party provisioners to receive a VM annotated with that label which does no good if you want to separate out those VMs by provisioner.
This PR changes the logic for labeling such that any VM labeled with a non-empty (!= "")
hobbyfarm.io/provisioner
label will be treated as external.Only those VMs that have either an empty label or a nonexistent label of
hobbyfarm.io/provisioner
will be handled by the internal TFP.