Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated legend hints across countries #80

Closed
ivan-aksamentov opened this issue Feb 2, 2021 · 0 comments · Fixed by #87
Closed

Avoid duplicated legend hints across countries #80

ivan-aksamentov opened this issue Feb 2, 2021 · 0 comments · Fixed by #87
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ivan-aksamentov
Copy link
Collaborator

The issue is raised in this comment: #77 (comment)

If two countries have the same color they are indistiguishable in tooltips and filtering sidebar. They can be distinguished in plots, because the lines have different styles (e.g. solid vs dashed).

We could solve this by drawing short pieces of lines instead of circles in tooltips and filtering panel.
@ivan-aksamentov ivan-aksamentov added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers needs triage Pending maintainers' attention labels Feb 2, 2021
@ivan-aksamentov ivan-aksamentov mentioned this issue Feb 2, 2021
Merged
@ivan-aksamentov ivan-aksamentov removed the needs triage Pending maintainers' attention label Feb 2, 2021
@ivan-aksamentov ivan-aksamentov mentioned this issue Feb 2, 2021
Open
ivan-aksamentov added a commit that referenced this issue Feb 8, 2021
@ivan-aksamentov
feat: use styled lines instead of colored circles on "per variant" page
20960a0 
Resolves #80

This replaces colored circles with short colored dashed lines as icons for country entries in plot tooltips and in filtering sidebar on "per variant" page. This way the countries with the same color look distinct if they have different line styles. The colors and styles mimic those in the plot.

The issue of duplicated colors still persists on "per cluster" page, which still uses circles. Using dashed lines there makes less sense, as there are not line plots on that page. Let's discuss this issue separately.

Additionally, some colors were too pale even when circles were used. And now with lines, especially dashed, these elements are almost indistinguishable from the background. This is poor user experience, especially in terms of accessibility.

Related: #81
@ivan-aksamentov ivan-aksamentov mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use styled lines instead of colored circles on "per variant" page hodcroftlab/covariants
1 participant
@ivan-aksamentov