-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Attempt at USA 'Per Country' Page #136
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hodcroftlab/covariants/G6JY2HcqFTymbdaN7MBoauGC3xwP |
I removed duplicated components and added "Region switcher" component with buttons Merged US data into countries JSON. They now contain "regions" array as top level, and "World", "United States" and "Switzerland" being regions. New regions can be added here: covariants/scripts/convert_to_web_app_json.py Lines 342 to 346 in c7635f5
|
Did not mean to do that. Trying to undo. |
The last issue remaining here is to make the grey dots for states have colors. However, I don't think this need hold up the merge. I'm hoping we might still get the country flags worked in as pictures by modifications to PR #135 - and if that comes through, then we can do the same here! |
There is likely a lot to get upset about here in terms of programming, but I couldn't resist trying to put together a page that shows the per-country graphs but for... US states!
This is a work-in progress.
Things Emma can do, but needs to do:
scripts/try_state_data.py
into the main running script, or at least one that more formally branches from the main scriptPerStateIntro.md
and have this go into the page header instead ofPerCountryIntro.md
Things Emma doesn't know how to do:
Things to think about:
@ivan-aksamentov I'm sorry in advance for the fact that I'm sure this could be done much more neatly! I mostly copied and adapted. Please do tidy what should be tidier! 😬