fix: initial position for dpg.window with popup=True (#1975) #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: A window with popup=True is positioned incorrectly
assignees: @hoffstadt
Closes #1975
Description:
A window can be positioned at the mouse cursor automatically - this auto-positioning is used unless the window got a label at creation. However, the way all calls to DPG API are routed to
internal_dpg, the C++ implementation gets all possible parameters no matter whether the user specified them on the initial call. That is, even fordpg.window()withoutlabel=something, C++ will seelabel=Nonepassed in.This fix corrects auto-positioning by additionally checking that the label is not None.
Concerning Areas:
None.