mvNodeLink: Passing state to handlers instead of nullptr #2197 #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: mvNodeLink: Passing state to handlers instead of nullptr
assignees: @hoffstadt
Closes #2197
Description:
datainmvNodeLink::customActionis always null. Item handlers are supposed to get the item state instead, so this PR corrects that and passes the state to checkEvents, just like othercheckEventscalls inmvNodes.cppdo.Concerning Areas:
PR #2223 needs to be merged first - without that PR, the issue #2197 doesn't occur (it's masked by #2196), and therefore can't be tested for.