Expose nrSessions #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
requested changes
Jun 10, 2024
There was a problem hiding this comment.
I'd make the sessions getter returns _sessions instead, that's much simpler than introducing a new and somewhat unfortunately named property. The point of making sessions return an iterator was to avoid exposing a writable public API, but that was only for the sake of being defensive.
|
Nice, that's much easier/cleaner indeed. Updated |
kasperisager
requested changes
Jun 10, 2024
Co-authored-by: Kasper Isager Dalsgarð <kasperisager@hey.com>
kasperisager
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for metrics (otherwise the private prop
_sessionsneeds to be accessed to get the nr of sessions)