-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement blind relay support #135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
force-pushed
the
connection-relaying
branch
from
August 29, 2023 13:21
24b46de
to
ee8ce6e
Compare
kasperisager
changed the title
Implement connection relaying
Implement bridging relay support
Sep 8, 2023
kasperisager
force-pushed
the
connection-relaying
branch
from
September 8, 2023 13:05
cabbca7
to
ef128b6
Compare
mafintosh
reviewed
Sep 22, 2023
mafintosh
reviewed
Sep 22, 2023
mafintosh
reviewed
Sep 22, 2023
mafintosh
reviewed
Sep 22, 2023
Removed use of the connection pool for outbound connections to relays for now and instead destroy the relay socket when the raw stream closes. This isn't optimal, but should at least be correct. |
mafintosh
reviewed
Sep 22, 2023
mafintosh
reviewed
Sep 26, 2023
mafintosh
approved these changes
Sep 28, 2023
kasperisager
changed the title
Implement bridging relay support
Implement blind relay support
Sep 29, 2023
mafintosh
reviewed
Sep 29, 2023
mafintosh
reviewed
Sep 29, 2023
mafintosh
reviewed
Sep 29, 2023
@@ -9,10 +9,13 @@ async function runTests () { | |||
|
|||
await import('./announces.js') | |||
await import('./connections.js') | |||
await import('./holepuncher.js') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch
Thank you both of you, this is huge. 🙏🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements client connection support for the blind relay protocol (https://github.com/holepunchto/blind-relay). This allows peers running in both client and server mode to establish connections to other peers through blind relays. Additionally, an initial implementation of a connection pool has been added, providing a way to more efficiently manage and deduplicate connections to other peers.
When provided with a connection pool, peers will use the pool for outbound connections to blind relays.