Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LAN handshake failure leak #152

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix LAN handshake failure leak #152

merged 1 commit into from
Dec 1, 2023

Conversation

mafintosh
Copy link
Contributor

No description provided.

HDegroote
HDegroote approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@HDegroote HDegroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed with this fix, and the leak was fixed (swarm.server._holepunches no longer grows arbitrarily large). The other behaviour seems stable, so this PR looks good to me

@mafintosh mafintosh merged commit 7806daa into main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDegroote HDegroote HDegroote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafintosh @HDegroote