Bugfix: don't create an announcer if closing #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race condition triggered when
server.listen()
created the announcerhyperdht/lib/server.js
Lines 111 to 116 in 75059f5
after
server.close()
started executing but beforeawait this.dht.bind()
resolved, because thenthis._listening
is not yet true, andclose()
early returns if no listener is found:hyperdht/lib/server.js
Lines 83 to 86 in 75059f5
It's a catastrophic bug when it triggers, because an endless loop floods the CPU in
Announcer._background()
:hyperdht/lib/announcer.js
Lines 96 to 97 in 75059f5
NODE_DESTROYED
errors which are caught and ignored