Bugfix: server lifecycle when closing during listen #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a catastrophic bug when destroying a server while listen() is being called, but before the server added itself to the DHT's server-set. This resulted in the
_background
hyperdht/lib/announcer.js
Line 96 in 55536eb
The fix is to add the server to the DHT's server-set as soon as
listen()
is called, ensuring itsclose
function is always called when the DHT gets destroyed.If there originally was a reason not to do immediately add a new server to the DHT's server-set, I can instead look into reworking the lifecycle a bit more in depth.