-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass clientAddress to firewall #131
base: main
Are you sure you want to change the base?
Conversation
@mafintosh any chance of merging this? |
Can you explain the use case when its only for remote connections? |
We use mdns for discovery on the local network (and cases where there is no internet connectivity). We advertise a different port on mdns (which doesn't connect through hyperswarm, but uses secretStream directly). In order to avoid duplicate connections we want to block connections through hyperswarm from local IPs. It seems like the firewall is the best place to do this? |
Ok, we can add it to fix your immediate use case - will land local discovery at some point, but as a middle ground don't document it so its not guaranteed to be there in the future. |
Want me to remove the README change in this PR? |
ya |
Force-pushed to remove README changes |
It looks like this method call may also need to be updated. Is that right? Line 139 in 80ea460
@gmaclennan |
Pass through the
clientAddress
(from@hyperswarm.dht
) to theopts.firewall
function.