-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced tests timeouts with flush helper #165
Conversation
fdbb998
to
d76918c
Compare
CI is failing |
Yeah, I think we got lucky and discovered another flaky test relying on TIMEOUTS (it's not a test which was modified in this PR) Lines 360 to 402 in 2229393
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The flaky test discussed above needs to be fixed though, but can be in another PR
Edit: managed to reproduce the flakiness: https://github.com/holepunchto/hyperswarm/actions/runs/7170541056/job/19523507101 . It's pretty rare, 80 repetitions before it hit. Probably fixable by using the flush helper of this PR--will look into that once this is merged
This PR replaces the timeouts in tests that could be replaced by the flush helper. It does not replace back off timeouts because the logic for does tests do not allow the replacement.