Use safetyCatch err handlers instead of noop #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I could not figure out why the
noop
-err-listener was removed here:hyperswarm/index.js
Line 178 in 21390bf
If we want to be safe, we could remove both a noop and a safetyCatch handler there, although it seems plausible that neither is needed.
For now it's just removing a safetyCatch listener, which should be compat with hyperdht as it's no longer using noop handlers once holepunchto/hyperdht#154 is in