send keepalives to peers on a network change #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mafintosh - this works... ish. But it would probably work even better if we pessimistically began reconnecting to peers right away, then aborted the reconnecting if it turned out the connections were still alive. Got any ideas how to do that? |
|
Lets land this for now, making the call non optional |
|
For funsies I'm gonna test it real quick |
… feat/fast-keep-alive
|
Eh, my LAN connections are still so slow I can't really measure an improvement. But I have a really hard time imagining this could have a detrimental unforeseen result so I feel safe to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see any difference with or without this change. Still seems like an ungodly long time (5-8 seconds) between
NETWORK CHANGEand...stream-close.Can anyone else confirm / deny ?
Testing using my
test/manual/measure-reconnect.jsscript and switching networks.Note: I've even tried commenting out the
conn.setKeepAlive(5000)line intest/manual/measure-reconnect.jsto try and give this PR every advantage.